netdev - Re: [PATCH] bonding: set correct tx_queue_len for bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 30 Jul 2013 17:24:54 +0800
From:	Yang Yingliang <yangyingliang@...wei.com>
To:	David Miller <davem@...emloft.net>
CC:	<fubar@...ibm.com>, <andy@...yhouse.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] bonding: set correct tx_queue_len for bond_dev

On 2013/7/30 15:34, David Miller wrote:
> From: Yang Yingliang <yangyingliang@...wei.com>
> Date: Tue, 30 Jul 2013 15:20:42 +0800
> 
>> With htb, sch->limit is set from bond_dev->tx_queue_len which
>> is initialized to 0 in bond_setup.
> 
> This is intentional, software devices should not queue TX
> packets.

This makes software devices with htb qdisc can hold only
one packet, others are dropped.

Maybe sch->limit's default value which is 1 is too small. 
Instead of this patch, I'll send another patch to fix this 
value for fixing this issue.
> 
> You can only use the packet scheduler with hardware devices.
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html