netdev - Re: [PATCH net-next 1/5] bonding: convert to list API and replace bond's custom list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130731113717.32f48d71@nehalam.linuxnetplumber.net>
Date:	Wed, 31 Jul 2013 11:37:17 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Nikolay Aleksandrov <nikolay@...hat.com>
Cc:	netdev@...r.kernel.org, andy@...yhouse.net, davem@...emloft.net,
	fubar@...ibm.com
Subject: Re: [PATCH net-next 1/5] bonding: convert to list API and replace
 bond's custom list

On Wed, 31 Jul 2013 17:12:29 +0200
Nikolay Aleksandrov <nikolay@...hat.com> wrote:

> diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
> index 390061d..80e288c 100644
> --- a/drivers/net/bonding/bond_3ad.c
> +++ b/drivers/net/bonding/bond_3ad.c
> @@ -143,10 +143,13 @@ static inline struct bonding *__get_bond_by_port(struct port *port)
>   */
>  static inline struct port *__get_first_port(struct bonding *bond)
>  {
> +	struct slave *first_slave;
> +
>  	if (bond->slave_cnt == 0)
>  		return NULL;
> +	first_slave = bond_first_slave(bond);

As Jay said, it would be be better to have bond_first_slave return
NULL (if no slaves), and eliminate slave_cnt. It would also fix
a race here between slave_cnt and all slave's being removed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html