netdev - Re: [PATCH] net/fec: Don't let ndo_start_xmit return NETDEV_TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130731.115101.340503855490269301.davem@davemloft.net>
Date:	Wed, 31 Jul 2013 11:51:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	u.kleine-koenig@...gutronix.de
Cc:	netdev@...r.kernel.org, fabio.estevam@...escale.com,
	Frank.Li@...escale.com, shawn.guo@...aro.org,
	kernel@...gutronix.de, hector.palacios@...i.com,
	tim.sander@....com, rostedt@...dmis.org, tglx@...utronix.de,
	stephen@...workplumber.org, B38611@...escale.com,
	florian@...nwrt.org, bhutchings@...arflare.com
Subject: Re: [PATCH] net/fec: Don't let ndo_start_xmit return
 NETDEV_TX_BUSY without link

From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Date: Wed, 31 Jul 2013 10:16:49 +0200

> On Tue, Jul 30, 2013 at 04:05:30PM -0700, David Miller wrote:
>> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>> Date: Tue, 30 Jul 2013 11:29:40 +0200
>> 
>> > Don't test for having link and let hardware deal with this situation.
>> > 
>> > Without this patch I see a machine running an -rt patched Linux being
>> > stuck in sch_direct_xmit when it looses link while there is still a
>> > packet to be sent. In this case the fec_enet_start_xmit routine returned
>> > NETDEV_TX_BUSY which makes the network stack reschedule the packet and
>> > so sch_direct_xmit calls fec_enet_start_xmit again.
>> > I failed to reproduce a complete hang without -rt, but I think the
>> > problem exists there, too.
>> > 
>> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>> 
>> Applied, thanks.
> Thanks, I see it as a264b981f2c76e281ef27e7232774bf6c54ec865 in net.git
> (i.e.
> https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=a264b981f2c76e281ef27e7232774bf6c54ec865)
> 
> You missed to take the
> 
> 	Acked-and-tested-by: Fugang Duan <B38611@...escale.com>

This is not an official tag recognized by patchwork, he should say:

Acked-by: Fugang Duan <B38611@...escale.com>
Tested-by: Fugang Duan <B38611@...escale.com>

> . If you want to fix that, you can do:
> 
> 	git filter-branch --msg-filter 'if test $GIT_COMMIT = a264b981f2c76e281ef27e7232774bf6c54ec865; then sed "/David/ i Acked-and-tested-by: Fugang Duan <B38611@...escale.com>"; else cat; fi' a264b981f2c76e281^..
> 
> on your master branch to add it to that commit.

My GIT history is permanent once pushed out, I cannot change history or else it
would break everyone cloning my tree.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html