netdev - Re: [PATCH net-next 1/6] qlcnic: Add ethtool statistics for board temperature.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130730.192723.699554467882059430.davem@davemloft.net>
Date:	Tue, 30 Jul 2013 19:27:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	himanshu.madhani@...gic.com
Cc:	netdev@...r.kernel.org, Dept_NX_Linux_NIC_Driver@...gic.com
Subject: Re: [PATCH net-next 1/6] qlcnic: Add ethtool statistics for board
 temperature.

From: Himanshu Madhani <himanshu.madhani@...gic.com>
Date: Tue, 30 Jul 2013 21:54:19 -0400

> From: Himanshu Madhani <himanshu.madhani@...gic.com>
> 
> o Added ethtool statistics to display adapter board
>   temperature.
> 
> Signed-off-by: Himanshu Madhani <himanshu.madhani@...gic.com>

A statistic is a count of events, this is not such a thing.

Furthermore, even if this fit the model of statistical events,
there is no way for the user to know what units the value is
in.

Sorry I'm not applying these patches.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html