netdev - Re: [PATCH 1/2] igb: Add macro for size of RETA indirection table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1375262094.2877.31.camel@jtkirshe-mobl>
Date:	Wed, 31 Jul 2013 02:14:54 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Laura Mihaela Vasilescu <laura.vasilescu@...edu.org>
Cc:	netdev@...r.kernel.org, carolyn.wyborny@...el.com,
	anjali.singhai@...el.com, alexander.h.duyck@...el.com
Subject: Re: [PATCH 1/2] igb: Add macro for size of RETA indirection table

On Wed, 2013-07-31 at 11:43 +0300, Laura Mihaela Vasilescu wrote:
> Signed-off-by: Laura Mihaela Vasilescu <laura.vasilescu@...edu.org>
> ---
>  drivers/net/ethernet/intel/igb/igb.h      |    2 ++
>  drivers/net/ethernet/intel/igb/igb_main.c |    2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-) 

Not sure if I mentioned it in your first submission, if I did not then
my bad. The title of your patch is descriptive of the changes, but it is
always nice to have a detailed patch description.  I noticed your second
patch is similar to the first, in that it does not have a detailed patch
description.

Information that would be good to include in the patch description is:
- why the change or reason for the change
- advantages/disadvantages to the change

Laura please re-submit your two patches with a detailed/meaningful patch
description to at least the second patch (but both would be great).

Think of it this way, if someone were to look at your changes 10 years
from now and did not understand why the change, your patch description
would explain all.

Cheers,
Jeff

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)