netdev - Re: [PATCH 2/2 v2] igb: Expose RSS indirection table for ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1375272802.2877.35.camel@jtkirshe-mobl>
Date:	Wed, 31 Jul 2013 05:13:22 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Laura Mihaela Vasilescu <laura.vasilescu@...edu.org>
Cc:	netdev@...r.kernel.org, carolyn.wyborny@...el.com,
	anjali.singhai@...el.com, alexander.h.duyck@...el.com
Subject: Re: [PATCH 2/2 v2] igb: Expose RSS indirection table for ethtool

On Wed, 2013-07-31 at 14:47 +0300, Laura Mihaela Vasilescu wrote:
> This patch adds the ethtool callbacks necessary to change the RETA
> indirection table from userspace.
> 
> In order to achieve this, we add the indirection table field
> (rss_indir_tbl)
> in the board specific data structure (struct igb_adapter) to preserve
> the
> values across hardware resets.
> 
> The indirection table must be initialized with default values in the
> following cases:
>         * at module init time
>         * when the number of RX queues changes.
> For this reason we add a new field (rss_indir_tbl_init) in igb_adapter
> that keeps track of the number of RX queues. Whenever the number of RX
> queues changes, the rss_indir_tbl is modified and initialized with
> default
> values. The rss_indir_tbl_init is updated accordingly.
> 
> Signed-off-by: Laura Mihaela Vasilescu <laura.vasilescu@...edu.org>
> ---
> Changes since v1:
>         * enhance commit description
> 
>  drivers/net/ethernet/intel/igb/igb.h         |    3 +
>  drivers/net/ethernet/intel/igb/igb_ethtool.c |   87
> ++++++++++++++++++++++++++
>  drivers/net/ethernet/intel/igb/igb_main.c    |   28 +++------
>  3 files changed, 97 insertions(+), 21 deletions(-) 

Added to my queue, thanks again Laura!

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)