netdev - Re: [PATCH] checkpatch: Warn when using extern with function prototypes in .h files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51FA5BFF.6050901@broadcom.com>
Date:	Thu, 1 Aug 2013 15:00:47 +0200
From:	"Arend van Spriel" <arend@...adcom.com>
To:	"David Howells" <dhowells@...hat.com>
cc:	"Joe Perches" <joe@...ches.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Andy Whitcroft" <apw@...onical.com>,
	"Hannes Frederic Sowa" <hannes@...essinduktion.org>,
	"Cong Wang" <xiyou.wangcong@...il.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Warn when using extern with function
 prototypes in .h files

On 08/01/2013 02:21 PM, David Howells wrote:
> Joe Perches <joe@...ches.com> wrote:
>
>> Using the extern keyword on function prototypes is superfluous
>> visual noise so suggest removing it.
>>
>> Using extern can cause unnecessary line wrapping at 80 columns
>> and unnecessarily long multi-line function prototypes.
>>
>> Suggested-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
>> Signed-off-by: Joe Perches <joe@...ches.com>
>
> Nak.
>
> The "extern" makes it much easier to pick out at a glance.

Really? Grouping function prototypes within the header file is much more 
helpful for spotting them.

Regards,
Arend

> Please standardise on there _being_ externs if you must do this.
>
> It's gratuitous change anyway and not worth the churn.
>
> David
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html