netdev - Re: [PATCH] macvlan: validate flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51FA7255.1070102@cogentembedded.com>
Date:	Thu, 01 Aug 2013 18:36:05 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
CC:	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Roopa Prabhu <roprabhu@...co.com>,
	John Fastabend <john.r.fastabend@...el.com>,
	Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] macvlan: validate flags

Hello.

On 01-08-2013 14:48, Michael S. Tsirkin wrote:

> commit df8ef8f3aaa6692970a436204c4429210addb23a

    Please also specify that commit's summary line in parens.
This is the only way to uniquely identify the commit, and it's the requirement 
that came originally from Linus AFAIK.

> added a flags field to macvlan, which can be
> controlled from userspace.
> The idea is to make the interface future-proof
> so we can add flags and not new fields.

> However, flags value isn't validated, as a result,
> userspace can't detect which flags are supported.

> Cc: "David S. Miller" <davem@...emloft.net>
> CC: Roopa Prabhu <roprabhu@...co.com>
> Cc: John Fastabend <john.r.fastabend@...el.com>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html