netdev - Re: [PATCH v2] sis900: Fix the tx queue timeout issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130801.131537.1412986626285577773.davem@davemloft.net>
Date:	Thu, 01 Aug 2013 13:15:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	B38611@...escale.com
Cc:	kda@...ux-powerpc.org, venza@...wnhat.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2] sis900: Fix the tx queue timeout issue

From: Duan Fugang-B38611 <B38611@...escale.com>
Date: Thu, 1 Aug 2013 15:50:51 +0000

> On Thursday, August 01, 2013 at 3:01 PM, Denis Kirjanov wrote:
> 
>> @@ -1613,9 +1613,12 @@ sis900_start_xmit(struct sk_buff *skb, struct net_device *net_dev)
>> 	unsigned int  count_dirty_tx;
>> 
>> 	/* Don't transmit data before the complete of auto-negotiation */
>> -	if(!sis_priv->autong_complete){
>> -		netif_stop_queue(net_dev);
>> -		return NETDEV_TX_BUSY;
>> +	if (unlikely(!sis_priv->autong_complete)) {
>> +		if (netif_msg_tx_err(sis_priv) && net_ratelimit())
>> +			netdev_dbg(net_dev, "Auto negotiation in progress\n");
>> +		net_dev->stats.tx_dropped++;
>> +		dev_kfree_skb(skb);
>> +		return NETDEV_TX_OK;
>>  	}
> 
> I always insist on that tx queue timeout is caused by un-correctly phy link handler flow.
> The link up handler flow: Auto-negotiation done-> netif_carrier_on()
>  
> The issue cannot be processed in xmit callback, which must be handled in link adjust process.

I completely agree, if sis_priv->autonet_complete is false this driver _MUST_
keep netif_carrier_off() until it becomes true.

This patch is not the correct fix for this problem, please fix it correctly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html