lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 31 Jul 2013 17:04:46 -0700 (PDT) From: David Miller <davem@...emloft.net> To: joe@...ches.com Cc: jonas.jensen@...il.com, netdev@...r.kernel.org, linux-doc@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, arm@...nel.org, florian@...nwrt.org Subject: Re: [PATCH v3] net: Add MOXA ART SoCs ethernet driver From: Joe Perches <joe@...ches.com> Date: Wed, 31 Jul 2013 11:56:38 -0700 >> + if (ui & (RX_ERR | CRC_ERR | FTL | RUNT | RX_ODD_NB)) { >> + netdev_err(ndev, "packet error\n"); > > This is generally a bad idea as it can flood > the log. It's probably better to remove it. > If you really want logging, then at least use > net_ratelimit(). Generally, the stats are > enough. ... >> + priv->stats.rx_dropped++; >> + priv->stats.rx_errors++; > [] >> +static int moxart_mac_start_xmit(struct sk_buff *skb, struct net_device *ndev) > [] >> + if (txdesc->txdes0.ubit.tx_dma_own) { >> + netdev_err(ndev, "no TX space for packet\n"); >> + priv->stats.tx_dropped++; > > here too. Agreed, these should not be logged, the statistics are sufficient. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists