netdev - Re: [Patch net-next 1/2] net: fix a compile error when CONFIG_NET_LL_RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1375344487.7780.14.camel@cr0>
Date:	Thu, 01 Aug 2013 16:08:07 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Eliezer Tamir <eliezer.tamir@...ux.intel.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch net-next 1/2] net: fix a compile error when
 CONFIG_NET_LL_RX_POLL is not set

On Thu, 2013-08-01 at 09:54 +0300, Eliezer Tamir wrote:
> On 01/08/2013 06:10, Cong Wang wrote:
> > From: Cong Wang <amwang@...hat.com>
> > 
> > When CONFIG_NET_LL_RX_POLL is not set, I got:
> > 
> > net/socket.c: In function ‘sock_poll’:
> > net/socket.c:1165:4: error: implicit declaration of function ‘sk_busy_loop’ [-Werror=implicit-function-declaration]
> > 
> > Fix this by adding a nop when !CONFIG_NET_LL_RX_POLL.
> > 
> 
> Good catch!
> 
> There is a placeholder function, but it has a typo in the name.
> With all the renaming I made a mistake and called the do-nothing
> function sk_busy_poll while the implemented function is called sk_busy_loop.
> 
> so what we need is to rename sk_busy_loop() into sk_busy_poll.
> 

Ok.

Thinking about it again, what is the point of your commit commit
89bf1b5a683df497c572c4d3bd3f9c9aa919d773 (net: remove NET_LL_RX_POLL
config menue)? After that commit, CONFIG_NET_LL_RX_POLL is not visible
by user and no other configs select it, also since it defaults to y, it
will be _always_ enabled. If this is really what you want, we can simply
remove all !CONFIG_NET_LL_RX_POLL code.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html