netdev - Re: [Patch net-next 1/2] net: fix a compile error when CONFIG_NET_LL_RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130801.225147.1055884690165323608.davem@davemloft.net>
Date:	Thu, 01 Aug 2013 22:51:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eliezer.tamir@...ux.intel.com
Cc:	amwang@...hat.com, netdev@...r.kernel.org
Subject: Re: [Patch net-next 1/2] net: fix a compile error when
 CONFIG_NET_LL_RX_POLL is not set

From: Eliezer Tamir <eliezer.tamir@...ux.intel.com>
Date: Fri, 02 Aug 2013 06:04:11 +0300

> On 01/08/2013 23:03, David Miller wrote:
>> From: Cong Wang <amwang@...hat.com>
>> Date: Thu, 01 Aug 2013 16:08:07 +0800
>> 
>>> Thinking about it again, what is the point of your commit commit
>>> 89bf1b5a683df497c572c4d3bd3f9c9aa919d773 (net: remove NET_LL_RX_POLL
>>> config menue)? After that commit, CONFIG_NET_LL_RX_POLL is not visible
>>> by user and no other configs select it, also since it defaults to y, it
>>> will be _always_ enabled. If this is really what you want, we can simply
>>> remove all !CONFIG_NET_LL_RX_POLL code.
>> 
>> Yes we could do that, it has no dependencies which is the usual reason
>> to have a hidden Kconfig var like this.
> 
> I think we still need a config option that depends on net and the
> placeholder code.
> What happens then if someone does not configure networking?
> Won't this break select and poll?

Good point.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html