[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20130802.220310.447316606630944097.davem@davemloft.net>
Date: Fri, 02 Aug 2013 22:03:10 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: shhuiw@...il.com
Cc: kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH][RESEND] vlan: cleanup the usage of vlan_dev_priv(dev)
From: Wang Sheng-Hui <shhuiw@...il.com>
Date: Sat, 03 Aug 2013 10:01:54 +0800
> This patch cleanup 2 points for the usage of vlan_dev_priv(dev):
> * In vlan_dev.c/vlan_dev_hard_header, we should use the var *vlan
> * directly
> after grabing the pointer at the beginning with
> *vlan = vlan_dev_priv(dev);
> when we need to access the fields of *vlan.
> * In vlan.c/register_vlan_device, add the var *vlan pointer
> struct vlan_dev_priv *vlan;
> to cleanup the code to access the fields of vlan_dev_priv(new_dev).
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@...il.com>
> ---
> net/8021q/vlan.c | 12 +++++++-----
> net/8021q/vlan_dev.c | 6 +++---
> 2 files changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
> index 2fb2d88..b9d3d7e 100644
> --- a/net/8021q/vlan.c
> +++ b/net/8021q/vlan.c
> @@ -210,6 +210,7 @@ out_vid_del:
> static int register_vlan_device(struct net_device *real_dev, u16
> vlan_id)
This still doesn't apply, because your email client corrupted
the patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists