netdev - Re: [PATCH] vlan: cleanup the usage of vlan_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130802.173311.1369362183750230796.davem@davemloft.net>
Date:	Fri, 02 Aug 2013 17:33:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shhuiw@...il.com
Cc:	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH] vlan: cleanup the usage of vlan_dev_priv(dev)

From: Wang Sheng-Hui <shhuiw@...il.com>
Date: Sat, 03 Aug 2013 08:22:42 +0800

> This patch cleanup 2 points for the usage of vlan_dev_priv(dev):
> 	* In vlan_dev.c/vlan_dev_hard_header, we should use the var *vlan
> 	* directly
> 	  after grabing the pointer at the beginning with
> 	      *vlan = vlan_dev_priv(dev);
>       when we need to access the fields of *vlan.
> 	* In vlan.c/register_vlan_device, add the var *vlan pointer
> 	      struct vlan_dev_priv *vlan;
> 	  to cleanup the code to access the fields of vlan_dev_priv(new_dev).
> 
> Signed-off-by: Wang Sheng-Hui <shhuiw@...il.com>

This patch doesn't even come close to applying to the net-next tree:

patching file net/8021q/vlan.c
Hunk #1 FAILED at 210.
Hunk #2 succeeded at 260 with fuzz 2.
1 out of 2 hunks FAILED -- saving rejects to file net/8021q/vlan.c.rej
patching file net/8021q/vlan_dev.c
Hunk #1 FAILED at 107.
Hunk #2 FAILED at 133.
2 out of 2 hunks FAILED -- saving rejects to file net/8021q/vlan_dev.c.rej

Please respin your changes and resubmit, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html