netdev - Re: [PATCH] fib_rules: fix suppressor names and default values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130803.104125.609502695540219854.davem@davemloft.net>
Date:	Sat, 03 Aug 2013 10:41:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	stefan.tomanek@...tarbyte.de
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] fib_rules: fix suppressor names and default values

From: David Miller <davem@...emloft.net>
Date: Sat, 03 Aug 2013 10:37:22 -0700 (PDT)

> From: Stefan Tomanek <stefan.tomanek@...tarbyte.de>
> Date: Sat, 3 Aug 2013 14:14:43 +0200
> 
>> This change brings the suppressor attribute names into line; it also changes
>> the data types to provide a more consistent interface.
>> 
>> While -1 indicates that the suppressor is not enabled, values >= 0 for
>> suppress_prefixlen or suppress_ifgroup  reject routing decisions violating the
>> constraint.
>> 
>> This changes the previously presented behaviour of suppress_prefixlen, where a
>> prefix length _less_ than the attribute value was rejected. After this change,
>> a prefix length less than *or* equal to the value is considered a violation of
>> the rule constraint.
>> 
>> It also changes the default values for default and newly added rules (disabling
>> any suppression for those).
>> 
>> Signed-off-by: Stefan Tomanek <stefan.tomanek@...tarbyte.de>
> 
> Applied, thanks.

I had to fix the following obvious typo:

diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c
index 47916b0..2e65413 100644
--- a/net/core/fib_rules.c
+++ b/net/core/fib_rules.c
@@ -351,7 +351,7 @@ static int fib_nl_newrule(struct sk_buff *skb, struct nlmsghdr* nlh)
 	if (tb[FRA_SUPPRESS_IFGROUP])
 		rule->suppress_ifgroup = nla_get_u32(tb[FRA_SUPPRESS_IFGROUP]);
 	else
-		rule->suppress_ifgroup -1;
+		rule->suppress_ifgroup = -1;
 
 	if (!tb[FRA_PRIORITY] && ops->default_pref)
 		rule->pref = ops->default_pref(ops);

Are you even looking at the build of the code you are submitting?
Because here the compiler told me:

net/core/fib_rules.c: In function ‘fib_nl_newrule’:
net/core/fib_rules.c:354:3: warning: statement with no effect [-Wunused-value]