netdev - RE: [PATCH v3] net/phy: micrel: Add OF configuration support for ksz9021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9848F2DB572E5649BA045B288BE08FBE015EE4A2@039-SN2MPN1-023.039d.mgd.msft.net>
Date:	Mon, 5 Aug 2013 03:03:55 +0000
From:	Duan Fugang-B38611 <B38611@...escale.com>
To:	Sean Cross <xobs@...agi.com>
CC:	Sascha Hauer <s.hauer@...gutronix.de>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: RE: [PATCH v3] net/phy: micrel: Add OF configuration support for
 ksz9021

From: Sean Cross [mailto:xobs@...agi.com]
Data: Monday, August 05, 2013 10:24 AM

> > > +Example:
> > > + &enet {
> > > + micrel,clk-control-pad-skew = <0xf0f0>;  micrel,rx-data-pad-skew =
> > > +<0x0000>;  micrel,tx-data-pad-skew = <0xffff>;  status = "okay";
> > > +};
> > > +
> >
> >
> >
> > The phy binding must be the phy node, not the ethernet node.
> > Pls refer to:
> > Documentation/devicetree/booting-without-of.txt
> > Documentation/devicetree/bindings/net/phy.txt
> 
> This won't necessarily work.  In my board, I don't think it's possible to
> manually specify the PHY, as most of the fields required by the OF PHY
> node don't apply to this device (at least according to phy.txt).  There
> are no interrupts, no interrupt parent, and it's unclear what the reg or
> linux,phandle fields do.  All of these are required fields, none of which
> seem to apply to this particular board.  Furthermore, it doesn't seem to
> be possible to specify a particular PHY, such as the ksz9021.
> 
> I see the pattern of getting OF settings from a parent's node used
> elsewhere in the kernel.  For example, in mmc_of_parse(), or more
> similarly in the chipidea ci_hdrc_probe() driver.

Yes, the patch is only reasonable for your platform, but it is the phy driver for different platforms that you must considerate.
Please add more example cases in binding doc.