netdev - Re: [PATCH] lto, wan/sbni: Make inline assembler symbols visible and assembler global

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130805.160921.1993558223692145813.davem@davemloft.net>
Date:	Mon, 05 Aug 2013 16:09:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	andi@...stfloor.org
Cc:	netdev@...r.kernel.org, ak@...ux.intel.com
Subject: Re: [PATCH] lto, wan/sbni: Make inline assembler symbols visible
 and assembler global

From: Andi Kleen <andi@...stfloor.org>
Date: Tue, 6 Aug 2013 01:05:35 +0200

> On Mon, Aug 05, 2013 at 03:33:23PM -0700, David Miller wrote:
>> From: Andi Kleen <andi@...stfloor.org>
>> Date: Mon,  5 Aug 2013 15:18:14 -0700
>> 
>> > From: Andi Kleen <ak@...ux.intel.com>
>> > 
>> > - Inline assembler defining C callable code has to be global
>> > - The function has to be visible
>> > 
>> > Do this in wan/sbni
>> > 
>> > Signed-off-by: Andi Kleen <ak@...ux.intel.com>
>> 
>> Please just make it use the standard lib/ CRC routines instead.
> 
> The problem is I don't have this hardware, and I don't think
> I can do such a change without testing it.

I say you can, having assembly in here for something as fundamental
as this is pointless.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html