netdev - Re: [PATCH net v4 2/6] bnx2x: protect different statistics flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130805.162618.882986953709212779.davem@davemloft.net>
Date:	Mon, 05 Aug 2013 16:26:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dmitry@...adcom.com
Cc:	netdev@...r.kernel.org, eilong@...adcom.com, ariele@...adcom.com
Subject: Re: [PATCH net v4 2/6] bnx2x: protect different statistics flows

From: "Dmitry Kravkov" <dmitry@...adcom.com>
Date: Tue, 6 Aug 2013 00:35:40 +0300

> Add locking to protect different statistics flows from
> running simultaneously.
> This in order to serialize statistics requests sent to FW,
> otherwise two outstanding queries may cause FW assert.
> 
> Signed-off-by: Dmitry Kravkov <dmitry@...adcom.com>
> Signed-off-by: Ariel Elior <ariele@...adcom.com>
> Signed-off-by: Eilon Greenstein <eilong@...adcom.com>

Please do not reinvent the wheel, use a standard semaphore
and down_timeout().

Anytime you feel that you have to implement your own fancy locking
primitives, you are doing it wrong.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html