| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130804171938.0d515529@nehalam.linuxnetplumber.net>
Date: Sun, 4 Aug 2013 17:19:38 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: David Miller <davem@...emloft.net>
Cc: netdev@...r.kernel.org
Subject: [PATCH net-next] bridge: fix rcu check warning in multicast port
group
Use of RCU here with out marked pointer and function doesn't match prototype
with sparse.
Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
--- a/net/bridge/br_mdb.c 2013-08-04 11:04:02.530470675 -0700
+++ b/net/bridge/br_mdb.c 2013-08-04 17:06:46.457182483 -0700
@@ -61,7 +61,8 @@ static int br_mdb_fill_info(struct sk_bu
for (i = 0; i < mdb->max; i++) {
struct net_bridge_mdb_entry *mp;
- struct net_bridge_port_group *p, **pp;
+ struct net_bridge_port_group *p;
+ struct net_bridge_port_group __rcu **pp;
struct net_bridge_port *port;
hlist_for_each_entry_rcu(mp, &mdb->mhash[i], hlist[mdb->ver]) {
--- a/net/bridge/br_private.h 2013-08-04 11:04:02.534470627 -0700
+++ b/net/bridge/br_private.h 2013-08-04 17:02:29.972453140 -0700
@@ -466,7 +466,7 @@ extern void br_multicast_free_pg(struct
extern struct net_bridge_port_group *br_multicast_new_port_group(
struct net_bridge_port *port,
struct br_ip *group,
- struct net_bridge_port_group *next,
+ struct net_bridge_port_group __rcu *next,
unsigned char state);
extern void br_mdb_init(void);
extern void br_mdb_uninit(void);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists