netdev - Re: [PATCH net] skge: add dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130804.183553.514470399074672614.davem@davemloft.net>
Date:	Sun, 04 Aug 2013 18:35:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	stephen@...workplumber.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] skge: add dma_mapping check

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Sun, 4 Aug 2013 17:22:34 -0700

> This old driver never checked for DMA mapping errors.
> Causing splats with the new DMA mapping checks:
> 	WARNING: at lib/dma-debug.c:937 check_unmap+0x47b/0x930()
> 	skge 0000:01:09.0: DMA-API: device driver failed to check map
> 
> Add checks and unwind code.
> 
> Reported-by: poma <pomidorabelisima@...il.com>
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>

Applied, but:

> -static void skge_rx_setup(struct skge_port *skge, struct skge_element *e,
> +static int skge_rx_setup(struct skge_port *skge, struct skge_element *e,
>  			  struct sk_buff *skb, unsigned int bufsize)

I reflowed the argument indentation for this in the final commit.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html