[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1375812195-6575-1-git-send-email-william.manley@youview.com>
Date: Tue, 6 Aug 2013 19:03:12 +0100
From: William Manley <william.manley@...view.com>
To: william.manley@...view.com, netdev@...r.kernel.org, bcrl@...ck.org,
luky-37@...mail.com, sergei.shtylyov@...entembedded.com,
bhutchings@...arflare.com, davem@...emloft.net,
hannes@...essinduktion.org
Subject: IGMP Unsolicited report interval patches
4th version of the patches.
The significant changes since last review are:
1. there is a new patch (2/3) as requested by Hannes.
2. the third patch now uses IN_DEV_CONF_GET in place of
IPV4_DEVCONF_ALL. This means that the unsolicited report interval can
now be configured on an interface-by-interface basis as I'd originally
intended but messed up in the implementation. One concern I have now
is that with this latest patch-set is that while
/proc/sys/net/ipv4/conf/eth0/igmp... will now have an effect
/proc/sys/net/ipv4/conf/all/igmp... will not. I'm not sure how to
resolve this.
One option would be to have a special value of -1 to mean use the
default so I could implement fall-back semantics. A down-side of this
approach is that it makes the meaning of the knobs less clear for
someone browsing through the filesystem. Another option would be to
remove the knob from all/ entirely, although I'm not sure how to do
this. Suggestions are very much welcome :)
Thanks
Will
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists