netdev - Re: [PATCH net-next 3/3] net: core: fix wrong linkage for ptype_base and ptype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1375823201.4004.13.camel@edumazet-glaptop>
Date:	Tue, 06 Aug 2013 14:06:41 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jean Sacren <sakiwit@...il.com>
Cc:	Daniel Borkmann <dborkman@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/3] net: core: fix wrong linkage for
 ptype_base and ptype_all symbols

On Tue, 2013-08-06 at 14:45 -0600, Jean Sacren wrote:

> I'm sorry to tell you but the patch is correct. Both symbols of
> ptype_{base,all} were wrongly declared as extern in net-procfs.c in the
> first place.

You are mistaken.

> > The net-procfs.c usage of ptype_* is there to show current pf_packet users
> > via seq_files in procfs. Your patch will just break this.
> 
> I validated it before I submitted the patch that all the symbols of
> ptype_{base,all} are used exclusively in net/core/net-procfs.c and
> net/core/dev.c but not outside of those two places. Therefore, your
> assumption for breakage is groundless.
> 
> As a kernel networking guru as you are, you shall have the lab and all
> sorts of test cases to validate patches. I'd love to run this type of
> testing by myself, but I don't have such resources. If you could test
> this patch in any of your setup and prove that I'm wrong, I'd extremely
> appreciate it. Thank you in advance.
> 
> I'm looking forward to being taught more.
> 


Well, the patch is wrong, for sure, and you cannot ask us to test your
patches.

Do not send patches that you cannot test yourself, please.

Try this before/after your patch

cat /proc/net/ptype



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html