netdev - Re: linux-next: Tree for Aug 6 [ wireless | iwlwifi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1375826322.10459.6.camel@jlt4.sipsolutions.net>
Date:	Tue, 06 Aug 2013 23:58:42 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	sedat.dilek@...il.com
Cc:	David Miller <davem@...emloft.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	wireless <linux-wireless@...r.kernel.org>, netdev@...r.kernel.org
Subject: Re: linux-next: Tree for Aug 6 [ wireless | iwlwifi | mac80211 ? ]

On Tue, 2013-08-06 at 23:45 +0200, Johannes Berg wrote:

> I think skb->protocol is probably getting set up wrong, and just putting
> back the last two lines
> 
>         skb->protocol = proto;
>         skb->dev = dev;
> 
> is probably sufficient to fix wifi. If skb->protocol isn't set to
> ETH_P_PAE, then we'd drop the packet in the wifi stack - might be worth
> printing out what it's set to at the point where the skb->protocol
> assignment above was removed.
> 
> I'm trying to wrap my head around all this right now but I don't yet see
> how the code after the patch would not get skb->protocol correct.

Actually, I think that's not it, but the code now behaves totally
differently?

Say this is the frame data with two points marked:

(1)                   (2)
 | dst | src | ethtype | ... |

As I understand it (in my admittedly rather tired state), previously we
had

skb_network_header() == (1)
skb_mac_header()     == (1)
skb->data            == (1)

After calling eth_type_trans(), we get

skb_network_header() == (1)
skb_mac_header()     == (1)
skb->data            == (2)

I think? Maybe I'm totally confused though.

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html