netdev - Re: low latency/busy poll feedback and bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5200A8BC.4010402@linux.intel.com>
Date:	Tue, 06 Aug 2013 10:41:48 +0300
From:	Eliezer Tamir <eliezer.tamir@...ux.intel.com>
To:	Shawn Bohrer <sbohrer@...advisors.com>
CC:	Amir Vadai <amirv@...lanox.com>, netdev@...r.kernel.org
Subject: Re: low latency/busy poll feedback and bugs

On 06/08/2013 00:22, Shawn Bohrer wrote:
> 1) I'm testing with a Mellanox ConnectX-3 card.

There's your problem ;)

> 2) Why is LowLatencyRxPackets reported as a TcpExt stat?  Perhaps I've
> been confused and misguided but I've always assumed those are
> statistics related to TCP and this feature is protocol neutral.  I'm
> not entirely sure where it should be moved to perhaps IpExt?

Actually, after all of the rewrite this has gone through,
it's now at the Ethernet level, not even IP specific.

So where should it go?

Should we also rename this to BusyPollRxPackets?

> 3) I don't know if this was intentional, an oversight, or simply a
> missing feature but UDP multicast currently is not supported.  In
> order to add support I believe you would need to call
> sk_mark_napi_id() in __udp4_lib_mcast_deliver().  Assuming there isn't
> some intentional reason this wasn't done I'd be happy to test this and
> send a patch.

This is still WIP, so our goal was to make it easy to extend for new
cases and protocols.

For multicast, it is possible that incoming packets to come from more
than one port (and therefore more than one queue).
I'm not sure how we could handle that, but what we have today won't do
well for that use-case.

What do you use for testing?

-Eliezer
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html