netdev - Re: [PATCH 3/3] net: wireless: rt2x00: Staticize rt2x00queue_pause_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 6 Aug 2013 12:27:31 +0200
From:	Gertjan van Wingerde <gwingerde@...il.com>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	Ivo van Doorn <IvDoorn@...il.com>,
	Helmut Schaa <helmut.schaa@...glemail.com>
Subject: Re: [PATCH 3/3] net: wireless: rt2x00: Staticize rt2x00queue_pause_queue_nocheck()

On Tue, Aug 6, 2013 at 10:36 AM, Jingoo Han <jg1.han@...sung.com> wrote:
> rt2x00queue_pause_queue_nocheck()is used only in this file.
> Fix the following sparse warning:
>
> drivers/net/wireless/rt2x00/rt2x00queue.c:939:6: warning: symbol 'rt2x00queue_pause_queue_nocheck' was not declared. Should it be
> static?
>
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>

Acked-by: Gertjan van Wingerde <gwingerde@...il.com>

> ---
>  drivers/net/wireless/rt2x00/rt2x00queue.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00queue.c b/drivers/net/wireless/rt2x00/rt2x00queue.c
> index aa95c6c..6c8a33b 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00queue.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00queue.c
> @@ -936,7 +936,7 @@ void rt2x00queue_index_inc(struct queue_entry *entry, enum queue_index index)
>         spin_unlock_irqrestore(&queue->index_lock, irqflags);
>  }
>
> -void rt2x00queue_pause_queue_nocheck(struct data_queue *queue)
> +static void rt2x00queue_pause_queue_nocheck(struct data_queue *queue)
>  {
>         switch (queue->qid) {
>         case QID_AC_VO:
> --
> 1.7.10.4
>
>



-- 
---
Gertjan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html