netdev - [PATCH net-next v2 0/2] bonding: vlan handling changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1375785616-5349-1-git-send-email-nikolay@redhat.com>
Date:	Tue,  6 Aug 2013 12:40:14 +0200
From:	Nikolay Aleksandrov <nikolay@...hat.com>
To:	netdev@...r.kernel.org
Cc:	andy@...yhouse.net, fubar@...ibm.com, davem@...emloft.net
Subject: [PATCH net-next v2 0/2] bonding: vlan handling changes

From: Nikolay Aleksandrov <Nikolay Aleksandrov nikolay@...hat.com>

Hi,
In v2 of these patchset I've dropped the previous patch 01 (vlan 0 fix)
because it'll be taken care of later and these two patches are not
dependent on it.

Patch 01 - switches the bonding to the now standard vlan syncing functions
vlan_vids_add/del_by_dev() and removes the bonding specific ones. In v2
upon vlan addition failure we fail the enslavement with an error message
because otherwise we might delete vlans that weren't added by the bonding.
The only way this may happen is with ENOMEM currently, so we're in trouble
anyway.

Patch 02 - reverts vlan addition in case of bond_add_vlan failure because
otherwise we may get bad vlan refcounts in the slaves.
This patch is queued for net-next because a fix for -net without the list
conversion would mean taking care of special cases and would be really
ugly. Since this bug is not critical, I'd rather have the fix for net-next.
It can happen only with ENOMEM, so again we're already in trouble.

Patches 01 and 02 are not connected and if you decide to drop patch 02
please leave 01 (if accepted).

v2: See the notes, I've explained the changes together and by patch.

Nikolay Aleksandrov (2):
  bonding: change the bond's vlan syncing functions with the standard
    ones
  bonding: unwind on bond_add_vlan failure

 drivers/net/bonding/bond_main.c | 41 +++++++++--------------------------------
 1 file changed, 9 insertions(+), 32 deletions(-)

-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html