netdev - Re: Bug: alx: Atheros AR8131/AR8151/AR8152/AR8161 Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACtZaF+aamW_0P2O1zSGLWHmichAZKb96pC4GCCVZZXJsh8Y7g@mail.gmail.com>
Date:	Wed, 7 Aug 2013 12:32:22 +0600
From:	Kinley Dorji <kinleyd@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Johannes Berg <johannes@...solutions.net>,
	Stephen Hemminger <stephen@...workplumber.org>,
	netdev@...r.kernel.org
Subject: Re: Bug: alx: Atheros AR8131/AR8151/AR8152/AR8161 Ethernet driver

@Johannes Berg: > don't really care much for the
> stats in the system I'm using this device on - and based on the driver
> I'm not sure I'd use the chip for 'serious' work anyway :)

OTOH, conky users love having the stats up, even if they aren't precise. :)

There's one other point:

Before the mainlining of the alx drivers, the default settings for
Wake-on used to be d, whereas now it seems to be pg. This startled me
a couple of times with my computer turning on unexpectedly, having
been used to the previous defaults. Just FYI.

Other than that, I would like thank you all very much for your quick
responses and I look forward to having the stats code restored to the
alx drivers.

With best regards,

Kinley

On Tue, Aug 6, 2013 at 6:07 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Tue, 2013-08-06 at 13:32 +0200, Johannes Berg wrote:
>
>> I don't. There are some stats in the original code at
>> https://github.com/erikarn/alx, but I removed them because I didn't
>> really understand what was going on and don't really care much for the
>> stats in the system I'm using this device on - and based on the driver
>> I'm not sure I'd use the chip for 'serious' work anyway :)
>>
>
> OK, their code seems clean and should be copied/pasted.
>
>
>> FWIW, it had ndo_get_stats() but was updating the netdev->stats from
>> that handler and then returning them, which seemed a bit questionable.
>>
>
> Its fine, as updates of each field are atomic (unsigned long)
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html