| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 07 Aug 2013 10:47:13 -0700 (PDT) From: David Miller <davem@...emloft.net> To: eric.dumazet@...il.com Cc: johannes@...solutions.net, phil@....cc, sedat.dilek@...il.com, sfr@...b.auug.org.au, linux-next@...r.kernel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, hannes@...essinduktion.org, linux-wireless@...r.kernel.org, linville@...driver.com Subject: Re: linux-next: Tree for Aug 7 From: Eric Dumazet <eric.dumazet@...il.com> Date: Wed, 07 Aug 2013 09:40:09 -0700 > On Wed, 2013-08-07 at 18:22 +0200, Johannes Berg wrote: > >> Maybe. I haven't tested it, but I'm thinking that skb->data doesn't >> point to the start of the data frame in this case, since we now call >> eth_type_trans() which pulls the ethernet header. So if the device just >> transmits skb->len starting from skb->data, it'll be wrong, no? That >> seems a basic assumption though. > > Yes, it seems calling eth_type_trans() is not right here, and even could > crash. > > Sorry, for being vague, I am a bit busy this morning. Yes, this is absolutely the core problem, you absolute cannot call eth_type_trans() on the output path, it pulls off the ethernet header from the packet. That can't possibly work. I want a real fix submitted formally for this problem immediately, or else I'm reverting all of these changes this afternoon. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists