netdev - Re: [PATCH 1/4] drivers/net: enic: Adding support for Cisco Low Latency NIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1376073939.2087.146.camel@joe-AO722>
Date:	Fri, 09 Aug 2013 11:45:39 -0700
From:	Joe Perches <joe@...ches.com>
To:	Neel Patel <neepatel@...co.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/4] drivers/net: enic: Adding support for Cisco Low
 Latency NIC

On Fri, 2013-08-09 at 11:38 -0700, Neel Patel wrote:
> diff --git a/drivers/net/ethernet/cisco/enic/vnic_rq.c b/drivers/net/ethernet/cisco/enic/vnic_rq.c

> @@ -30,16 +30,15 @@
>  static int vnic_rq_alloc_bufs(struct vnic_rq *rq)
[]
>  		rq->bufs[i] = kzalloc(VNIC_RQ_BUF_BLK_SZ(count), GFP_ATOMIC);
> -		if (!rq->bufs[i])
> +		if (!rq->bufs[i]) {
> +			pr_err("Failed to alloc rq_bufs\n");

Please don't add OOM messages.

A generic dump_stack() showing the location is
already done by the mm subsystem.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html