netdev - Re: [PATCH 17/17] net:ethernet:lantiq_etop.c: Removed deprecated IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52054A49.6000008@gmail.com>
Date:	Sat, 10 Aug 2013 01:30:09 +0530
From:	Kumar Gaurav <kumargauravgupta3@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	davem@...emloft.net, jiri@...nulli.us, gregkh@...uxfoundation.org,
	yongjun_wei@...ndmicro.com.cn, konszert@...vell.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 17/17] net:ethernet:lantiq_etop.c: Removed deprecated
 IRQF_DISABLED

On Saturday 10 August 2013 01:08 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 08/09/2013 10:25 PM, Kumar Gaurav wrote:
>
>> Removed IRQF_DISABLED as it is deprecated and fixed a coding style issue
>> of more than 80 chars on single line by sliting the line in two.
>
>    That's clearly a material for 2 separate patches.
>
>> Signed-off-by: Kumar Gaurav <kumargauravgupta3@...il.com>
>> ---
>>   drivers/net/ethernet/lantiq_etop.c |    8 +++++---
>>   1 file changed, 5 insertions(+), 3 deletions(-)
>
>> diff --git a/drivers/net/ethernet/lantiq_etop.c 
>> b/drivers/net/ethernet/lantiq_etop.c
>> index bfdb0686..04c3a82 100644
>> --- a/drivers/net/ethernet/lantiq_etop.c
>> +++ b/drivers/net/ethernet/lantiq_etop.c
> [...]
>> @@ -653,7 +653,9 @@ ltq_etop_init(struct net_device *dev)
>>       if (err)
>>           goto err_netdev;
>>
>> -    /* Set addr_assign_type here, ltq_etop_set_mac_address would 
>> reset it. */
>> +    /* Set addr_assign_type here,
>> +     *ltq_etop_set_mac_address would reset it.
>
>    You forgot space after * here.
>
> WBR, Sergei
>
Okay i'll be sending them in separate and correcting a space issue as told.
thanks

Regards
Kumar Gaurav
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html