netdev - Re: [PATCH] net:ethernet:korina.c Removed IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5204961A.5020707@bfs.de>
Date:	Fri, 09 Aug 2013 09:11:22 +0200
From:	walter harms <wharms@....de>
To:	Joe Perches <joe@...ches.com>
CC:	Kumar Gaurav <kumargauravgupta3@...il.com>,
	David Miller <davem@...emloft.net>, dan.carpenter@...cle.com,
	emilio@...pez.com.ar, mugunthanvnm@...com, jg1.han@...sung.com,
	hsweeten@...ionengravers.com, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net:ethernet:korina.c Removed IRQF_DISABLED



Am 09.08.2013 04:39, schrieb Joe Perches:
> On Fri, 2013-08-09 at 07:54 +0530, Kumar Gaurav wrote:
>> On Friday 09 August 2013 03:03 AM, Joe Perches wrote:
>>> On Thu, 2013-08-08 at 14:20 -0700, David Miller wrote:
>>>> So what's the problem again? :-)
>> I'm quite new to kernel development. I saw in one of the patches which 
>> fixes IRQF_DISABLED issue by removing so i did.
> 
> Hi Kumar.
> 
> No worries, welcome.
> 
>>> Wouldn't it be better to do a sed 's/IRQF_DISABLED/0/' instead?
>>> Maybe Kumar wants to/is doing that?
>> Yes i wanted to do the same and i retrieved list of all programs 
>> containing IRQF_DISABLED but i didn't wanted to send all of them in one 
>> patch. I would be sending them for one program in one patch.
> 
> You should definitely not send a single patch.
> 
> $ git grep -w --name-only IRQF_DISABLED | wc -l
> 245
> 
> I think that's way too many modified files for a
> single patch.
> 
> If you do it, please remember to change bits like
> "(IRQF_<foo> | IRQF_DISABLED)" so that instead of
> "(IRQF_<foo> | 0)", you use just "IRQF_<foo>".
> 
> And, maybe it'd be better to use IRQF_TRIGGER_NONE
> instead of 0.
> 


yes !

re,
 wh


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html