netdev - Re: [PATCH] gianfar: add support for LFC (Lossless Flow Control)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1376037546.2087.69.camel@joe-AO722>
Date:	Fri, 09 Aug 2013 01:39:06 -0700
From:	Joe Perches <joe@...ches.com>
To:	Lutz Jaenicke <ljaenicke@...ominate.com>
Cc:	netdev@...r.kernel.org,
	Claudiu Manoil <claudiu.manoil@...escale.com>,
	Ben Hutchings <bhutchings@...arflare.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] gianfar: add support for LFC (Lossless Flow Control)

On Fri, 2013-08-09 at 10:26 +0200, Lutz Jaenicke wrote:
> Implement Lossless Flow Control (let the MAC automatically generate
> PAUSE frames in case of too much incoming traffic.
> Selection of this feature is performed via device tree parameter.
> The board (and processor) specific device tree is authoritative wrt this
> information.

Just a trivial note:

> diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
[]
> @@ -169,10 +169,12 @@ static void gfar_init_rxbdp(struct gfar_priv_rx_q *rx_queue, struct rxbd8 *bdp,
[]
> +	u32 *rfbptr;
[]
> @@ -222,6 +225,11 @@ static int gfar_init_bds(struct net_device *ndev)
[]
> +		if (priv->device_flags & FSL_GIANFAR_DEV_HAS_LFC)
> +			rx_queue->rfbptr = rfbptr;
> +		else
> +			rx_queue->rfbptr = 0;

s/0/NULL/


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html