netdev - Re: [PATCH net] net: sctp: sctp_assoc_control_transport: fix MTU size in SCTP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5204F121.7080609@gmail.com>
Date:	Fri, 09 Aug 2013 09:39:45 -0400
From:	Vlad Yasevich <vyasevich@...il.com>
To:	Daniel Borkmann <dborkman@...hat.com>
CC:	davem@...emloft.net, kheiss@...il.com, netdev@...r.kernel.org,
	linux-sctp@...r.kernel.org, Neil Horman <nhorman@...driver.com>
Subject: Re: [PATCH net] net: sctp: sctp_assoc_control_transport: fix MTU
 size in SCTP_PF state

On 08/09/2013 09:09 AM, Daniel Borkmann wrote:
> The SCTP Quick failover draft [1] section 5.1, point 5 says that the cwnd
> should be 1 MTU. So, instead of 1, set it to 1 MTU.
>
>    [1] https://tools.ietf.org/html/draft-nishida-tsvwg-sctp-failover-05
>
> Reported-by: Karl Heiss <kheiss@...il.com>
> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>
> Cc: Neil Horman <nhorman@...driver.com>
> ---
>   net/sctp/associola.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/sctp/associola.c b/net/sctp/associola.c
> index bce5b79..ab67efc 100644
> --- a/net/sctp/associola.c
> +++ b/net/sctp/associola.c
> @@ -846,12 +846,12 @@ void sctp_assoc_control_transport(struct sctp_association *asoc,
>   		else
>   			spc_state = SCTP_ADDR_AVAILABLE;
>   		/* Don't inform ULP about transition from PF to
> -		 * active state and set cwnd to 1, see SCTP
> +		 * active state and set cwnd to 1 MTU, see SCTP
>   		 * Quick failover draft section 5.1, point 5
>   		 */
>   		if (transport->state == SCTP_PF) {
>   			ulp_notify = false;
> -			transport->cwnd = 1;
> +			transport->cwnd = asoc->pathmtu;
>   		}
>   		transport->state = SCTP_ACTIVE;
>   		break;
>

Acked-by: Vlad Yasevich <vyasevich@...il.com>

-vlad
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html