netdev - Re: [PATCH] net:ethernet:korina.c Removed IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1376065686.2087.102.camel@joe-AO722>
Date:	Fri, 09 Aug 2013 09:28:06 -0700
From:	Joe Perches <joe@...ches.com>
To:	Peter Senna Tschudin <peter.senna@...il.com>
Cc:	Kumar Gaurav <kumargauravgupta3@...il.com>,
	David Miller <davem@...emloft.net>,
	Dan Carpenter <dan.carpenter@...cle.com>, emilio@...pez.com.ar,
	mugunthanvnm@...com, jg1.han@...sung.com,
	hsweeten@...ionengravers.com, netdev <netdev@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net:ethernet:korina.c Removed IRQF_DISABLED

On Fri, 2013-08-09 at 17:53 +0200, Peter Senna Tschudin wrote:
> On Fri, Aug 9, 2013 at 5:14 PM, Joe Perches <joe@...ches.com> wrote:
> > On Fri, 2013-08-09 at 15:15 +0200, Peter Senna Tschudin wrote:
> >> Coccinelle (http://coccinelle.lip6.fr/) can help you in this task.
[]
> Peter's useful conversion won't find/convert cases where
> > IRQF_DISABLED is used in a #define like:
> >> diff --git a/drivers/net/ethernet/micrel/ks8851_mll.c b/drivers/net/ethernet/micrel/ks8851_mll.c
> >> []
> >> @@ -915,7 +915,7 @@ static int ks_net_open(struct net_device *netdev)
> >> []
> >> -#define        KS_INT_FLAGS    (IRQF_DISABLED|IRQF_TRIGGER_LOW)
> >> +#define        KS_INT_FLAGS    (IRQF_TRIGGER_LOW)

Hi again.

> Coccinelle works with macros,

Sometimes yes.  Perfectly?  No.

> the problem in this specific case [...]

Other problems exist.
#include processing is troublesome.

> But, I would prefer to remove this define instead of patching it,
> seems to make more sense to me.

That'd be OK with me too.

Anyway, the point was not that coccinelle is bad.

Cocinelle's output, just like output from sed or
any other automated tool, still needs thoughtful
investigation and review.

(did I mention Coccinelle's a way cool tool?)

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html