netdev - Re: [PATCH 2/2 net-next] net: attempt high order allocations in sock_alloc_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130810.011720.981603328762637226.davem@davemloft.net>
Date:	Sat, 10 Aug 2013 01:17:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, rientjes@...gle.com
Subject: Re: [PATCH 2/2 net-next] net: attempt high order allocations in
 sock_alloc_send_pskb()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 08 Aug 2013 14:38:47 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Adding paged frags skbs to af_unix sockets introduced a performance
> regression on large sends because of additional page allocations, even
> if each skb could carry at least 100% more payload than before.
> 
> We can instruct sock_alloc_send_pskb() to attempt high order
> allocations.
> 
> Most of the time, it does a single page allocation instead of 8.
> 
> I added an additional parameter to sock_alloc_send_pskb() to
> let other users to opt-in for this new feature on followup patches.
> 
> Tested:
> 
> Before patch :
> 
> $ netperf -t STREAM_STREAM 
> STREAM STREAM TEST
> Recv   Send    Send                          
> Socket Socket  Message  Elapsed              
> Size   Size    Size     Time     Throughput  
> bytes  bytes   bytes    secs.    10^6bits/sec  
> 
>  2304  212992  212992    10.00    46861.15   
> 
> After patch :
> 
> $ netperf -t STREAM_STREAM 
> STREAM STREAM TEST
> Recv   Send    Send                          
> Socket Socket  Message  Elapsed              
> Size   Size    Size     Time     Throughput  
> bytes  bytes   bytes    secs.    10^6bits/sec  
> 
>  2304  212992  212992    10.00    57981.11   
> 
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Great work, applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html