netdev - Re: [PATCH v2] tipc: avoid possible deadlock while enable and disable bearer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52086CB2.3050006@windriver.com>
Date:	Mon, 12 Aug 2013 13:03:46 +0800
From:	Ying Xue <ying.xue@...driver.com>
To:	David Miller <davem@...emloft.net>
CC:	<dingtianhong@...wei.com>, <jon.maloy@...csson.com>,
	<allan.stephens@...driver.com>,
	<tipc-discussion@...ts.sourceforge.net>, <netdev@...r.kernel.org>,
	<wangweidong1@...wei.com>
Subject: Re: [PATCH v2] tipc: avoid possible deadlock while enable and disable
 bearer

On 08/12/2013 12:59 PM, David Miller wrote:
> From: Ying Xue <ying.xue@...driver.com>
> Date: Fri, 9 Aug 2013 17:34:05 +0800
> 
>>
>>> The problem is that the tipc_link_delete() will cancel the timer disc_timeout() when
>>> the b_ptr->lock is hold, but the disc_timeout() still call b_ptr->lock to finish the
>>> work, so the dead lock occurs.
>>>
>>> We should unlock the b_ptr->lock when del the disc_timeout().
>>>
>>> Remove link_timeout() still met the same problem, the patch:
>>>
>>> http://article.gmane.org/gmane.network.tipc.general/4380
>>>
>>> fix the problem, so no need to send patch for fix link_timeout() deadlock warming.
>>>
>>> Signed-off-by: Wang Weidong <wangweidong1@...wei.com>
>>> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>
>>> Cc: Ying Xue <ying.xue@...driver.com>
>>
>> Ack-by: Ying Xue <ying.xue@...driver.com>
> 
> The proper syntax is "Acked-by: " not "Ack-by: "
> 

Thanks, I knew :)

Regards,
Ying

> Applied.
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html