netdev - Re: [PATCH] rtnetlink: rtnl_bridge_getlink: Call nlmsg_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52093E29.5010604@redhat.com>
Date:	Mon, 12 Aug 2013 15:57:29 -0400
From:	Vlad Yasevich <vyasevic@...hat.com>
To:	Asbjoern Sloth Toennesen <ast@...erby.net>
CC:	"David S. Miller" <davem@...emloft.net>,
	Stephen Hemminger <stephen@...workplumber.org>,
	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtnetlink: rtnl_bridge_getlink: Call nlmsg_find_attr()
 with ifinfomsg header

On 08/12/2013 12:30 PM, Asbjoern Sloth Toennesen wrote:
> Fix the iproute2 command `bridge vlan show`, after switching from
> rtgenmsg to ifinfomsg.
>
> Signed-off-by: Asbjoern Sloth Toennesen <ast@...erby.net>


Thanks..  I've still been using an older iproute version and didn't see 
this.


Reviewed-by: Vlad Yasevich <vyasevich@...il.com>
> ---
>   net/core/rtnetlink.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index 3de7408..a043171 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -2384,7 +2384,7 @@ static int rtnl_bridge_getlink(struct sk_buff *skb, struct netlink_callback *cb)
>   	struct nlattr *extfilt;
>   	u32 filter_mask = 0;
>
> -	extfilt = nlmsg_find_attr(cb->nlh, sizeof(struct rtgenmsg),
> +	extfilt = nlmsg_find_attr(cb->nlh, sizeof(struct ifinfomsg),
>   				  IFLA_EXT_MASK);
>   	if (extfilt)
>   		filter_mask = nla_get_u32(extfilt);
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html