netdev - Re: [PATCH] macvtap: fix two races

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130811.215049.2058314780489790321.davem@davemloft.net>
Date:	Sun, 11 Aug 2013 21:50:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	thuth@...ux.vnet.ibm.com, netdev@...r.kernel.org,
	vyasevic@...hat.com
Subject: Re: [PATCH] macvtap: fix two races

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 08 Aug 2013 08:06:14 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Since commit ac4e4af1e59e1 ("macvtap: Consistently use rcu functions"),
> Thomas gets two different warnings :
 ...
> And
 ...
> In the first case, macvtap_put_user() calls macvlan_count_rx()
> in a preempt-able context, and this is not allowed.
> 
> In the second case, macvtap_get_user() calls
> macvlan_start_xmit() with BH enabled, and this is not allowed.
>  
> Reported-by: Thomas Huth <thuth@...ux.vnet.ibm.com>
> Bisected-by: Thomas Huth <thuth@...ux.vnet.ibm.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Tested-by: Thomas Huth <thuth@...ux.vnet.ibm.com>
> Cc: Vlad Yasevich <vyasevic@...hat.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html