netdev - Re: [PATCH net] be2net: Clear any capability flags that driver is not interested in.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130813.152207.440378568111389533.davem@davemloft.net>
Date:	Tue, 13 Aug 2013 15:22:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sarveshwar.bandi@...lex.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] be2net: Clear any capability flags that driver is
 not interested in.

From: <sarveshwar.bandi@...lex.com>
Date: Mon, 12 Aug 2013 11:21:09 +0530

> From: Sarveshwar Bandi <sarveshwar.bandi@...lex.com>
> 
> It is possible for some versions of firmware to advertise capabilities that driver
> is not ready to handle. This may lead to controller stall. Clear all flags that driver
> is not interested in.
> 
> Signed-off-by: Sarveshwar Bandi <sarveshwar.bandi@...lex.com>

This is so ugly and hard to understand.

The issue is that the capabilities come from an external entity, in
be_cmd_get_func_config().

So that's the place where you should clear the bits that the drive
doesn't understand.

Also, put the new macro into a sane place like a header file close
to the existing individual BE_IF_FLAGS_* defines.  And name it sanely,
something like "BE_IF_FLAGS_ALL".
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html