netdev - Re: [PATCH net-next v2] ipv6: make unsolicited report intervals configurable for mld

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130813.155250.2046252303059223531.davem@davemloft.net>
Date:	Tue, 13 Aug 2013 15:52:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org, xiyou.wangcong@...il.com,
	william.manley@...view.com, bcrl@...ck.org, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH net-next v2] ipv6: make unsolicited report intervals
 configurable for mld

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Mon, 12 Aug 2013 13:28:17 +0200

> diff --git a/include/uapi/linux/ipv6.h b/include/uapi/linux/ipv6.h
> index 4bda4cf..315f133 100644
> --- a/include/uapi/linux/ipv6.h
> +++ b/include/uapi/linux/ipv6.h
> @@ -147,6 +147,8 @@ enum {
>  	DEVCONF_MAX_DESYNC_FACTOR,
>  	DEVCONF_MAX_ADDRESSES,
>  	DEVCONF_FORCE_MLD_VERSION,
> +	DEVCONF_MLDV1_UNSOLICITED_REPORT_INTERVAL,
> +	DEVCONF_MLDV2_UNSOLICITED_REPORT_INTERVAL,
>  	DEVCONF_ACCEPT_RA_DEFRTR,
>  	DEVCONF_ACCEPT_RA_PINFO,
>  	DEVCONF_ACCEPT_RA_RTR_PREF,

Since these these values are in an UAPI header, and thus exported to userspace,
you can't add new enumeration values in the middle.  Otherwise you'll change
the existing enumerations, which could break userspace.

You'll have to add these new values to the end.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html