netdev - Re: [PATCH net] ip_tunnel: Do not use inner ip-header-id for tunnel ip-header-id.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130813.165323.387925674219585747.davem@davemloft.net>
Date:	Tue, 13 Aug 2013 16:53:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	pshelar@...ira.com
Cc:	netdev@...r.kernel.org, jrajahalme@...ira.com, aatteka@...ira.com
Subject: Re: [PATCH net] ip_tunnel: Do not use inner ip-header-id for
 tunnel ip-header-id.

From: Pravin B Shelar <pshelar@...ira.com>
Date: Tue, 13 Aug 2013 01:41:06 -0700

> Using inner-id for tunnel id is not safe in some rare cases.
> E.g. packets coming from multiple sources entering same tunnel
> can have same id. Therefore on tunnel packet receive we
> could have packets from two different stream but with same
> source and dst IP with same ip-id which could confuse ip packet
> reassembly.
> 
> Following patch reverts optimization from commit
> 490ab08127 (IP_GRE: Fix IP-Identification.)
> 
> CC: Jarno Rajahalme <jrajahalme@...ira.com>
> CC: Ansis Atteka <aatteka@...ira.com>
> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html