netdev - Re: [PATCH 8/8] net: davinci_mdio: use platform_{get,set}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52098A87.3090703@huawei.com>
Date:	Tue, 13 Aug 2013 09:23:19 +0800
From:	Libo Chen <clbchenlibo.chen@...wei.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	David Miller <davem@...emloft.net>, <mugunthanvnm@...com>,
	<bigeasy@...utronix.de>, <prabhakar.csengg@...il.com>,
	<b-liu@...com>, <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Li Zefan <lizefan@...wei.com>
Subject: Re: [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()

On 2013/8/13 2:17, Sergei Shtylyov wrote:
> On 08/12/2013 05:25 PM, Libo Chen wrote:
> 
>> Use the wrapper functions for getting and setting the driver data using
>> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
>> so we can directly pass a struct platform_device.
> 
>> Signed-off-by: Libo Chen <libo.chen@...wei.com>
>> ---
>>   drivers/net/ethernet/ti/davinci_mdio.c |    4 +---
>>   1 files changed, 1 insertions(+), 3 deletions(-)
> 
>> diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
>> index 16ddfc3..2249b2c 100644
>> --- a/drivers/net/ethernet/ti/davinci_mdio.c
>> +++ b/drivers/net/ethernet/ti/davinci_mdio.c
> [...]
>> @@ -434,7 +433,6 @@ static int davinci_mdio_remove(struct platform_device *pdev)
>>       pm_runtime_put_sync(&pdev->dev);
>>       pm_runtime_disable(&pdev->dev);
>>
>> -    dev_set_drvdata(dev, NULL);
> 
>    Doesn't get described as well. I think you're mixing two types of changes in one patchset.
> 
> WBR, Sergei
> 

thanks for your attention!


Libo

> 
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html