netdev - Re: [PATCH 4/7] mfd: add MFD based flexcard driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130813095508.GA5109@lee--X1>
Date:	Tue, 13 Aug 2013 10:55:08 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Benedikt Spranger <b.spranger@...utronix.de>
Cc:	netdev@...r.kernel.org,
	Alexander Frank <Alexander.Frank@...rspaecher.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Holger Dengler <dengler@...utronix.de>
Subject: Re: [PATCH 4/7] mfd: add MFD based flexcard driver

On Tue, 13 Aug 2013, Benedikt Spranger wrote:

> This patch provides support for Eberpächer Flexcard. The Flexcard comes
> with two PCI bars, one for the glue layer and one for the "IPs". The
> second bar may have multiple other devices like flexray or d_can
> devices. The driver utilites the MFD framework and creates various
> subdevices. Not only for the additional "IPs" but also for the clock
> source and clockevent provided by the card.
> 
> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> Cc: Lee Jones <lee.jones@...aro.org>
> Signed-off-by: Benedikt Spranger <b.spranger@...utronix.de>
> Signed-off-by: Holger Dengler <dengler@...utronix.de>
> ---
>  drivers/mfd/Kconfig           |   40 ++
>  drivers/mfd/Makefile          |    2 +
>  drivers/mfd/flexcard-core.c   | 1059 +++++++++++++++++++++++++++++++++++++++++
>  drivers/mfd/flexcard-dma.c    |  561 ++++++++++++++++++++++
>  drivers/mfd/flexcard-irq.c    |  333 +++++++++++++
>  drivers/mfd/flexcard.h        |    8 +
>  include/linux/eray.h          |  650 +++++++++++++++++++++++++
>  include/linux/flexcard.h      |   95 ++++
>  include/uapi/linux/Kbuild     |    2 +
>  include/uapi/linux/eray.h     |   34 ++
>  include/uapi/linux/flexcard.h |  429 +++++++++++++++++
>  11 files changed, 3213 insertions(+)
>  create mode 100644 drivers/mfd/flexcard-core.c
>  create mode 100644 drivers/mfd/flexcard-dma.c
>  create mode 100644 drivers/mfd/flexcard-irq.c
>  create mode 100644 drivers/mfd/flexcard.h
>  create mode 100644 include/linux/eray.h
>  create mode 100644 include/linux/flexcard.h
>  create mode 100644 include/uapi/linux/eray.h
>  create mode 100644 include/uapi/linux/flexcard.h

Wow, this is a huge patch which is going to be an insanely long,
laborious and complex task to review it all.

Can you split this up into many patches? Adding functionality
incrementally instead of rolling it up into this ball of wax?

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html