netdev - Re: [PATCH 2/3 v2] ipv6: rename ADBG() to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130813113719.GF27385@order.stressinduktion.org>
Date:	Tue, 13 Aug 2013 13:37:19 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Ding Tianhong <dingtianhong@...wei.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Netdev <netdev@...r.kernel.org>,
	Patrick McHardy <kaber@...sh.net>,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH 2/3 v2] ipv6: rename ADBG() to pr_xxx()

On Tue, Aug 13, 2013 at 03:57:28PM +0800, Ding Tianhong wrote:
> According to Joe Perches opinions, the ADBG() was tedious and it is
> better to remove the KERN_<LEVEL>s and use the pr_xxx() instead of ADBG().
> 
> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>
> Cc: Joe Perches <joe@...ches.com>
> ---
>  net/ipv6/addrconf.c | 29 +++++++++--------------------
>  1 file changed, 9 insertions(+), 20 deletions(-)
> 
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 72911fd..2333fa7 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -95,15 +95,6 @@
>  #include <linux/seq_file.h>
>  #include <linux/export.h>
>  
> -/* Set to 3 to get tracing... */
> -#define ACONF_DEBUG 2
> -
> -#if ACONF_DEBUG >= 3
> -#define ADBG(x) printk x

Please either change this to pr_warning, pr_err.

> -#else
> -#define ADBG(x)
> -#endif
> -
>  #define	INFINITY_LIFE_TIME	0xFFFFFFFF
>  
>  static inline u32 cstamp_delta(unsigned long cstamp)
> @@ -369,9 +360,8 @@ static struct inet6_dev *ipv6_add_dev(struct net_device *dev)
>  	dev_hold(dev);
>  
>  	if (snmp6_alloc_dev(ndev) < 0) {
> -		ADBG((KERN_WARNING
> -			"%s: cannot allocate memory for statistics; dev=%s.\n",
> -			__func__, dev->name));
> +		pr_warning("%s: cannot allocate memory for statistics; dev=%s.\n",
> +			__func__, dev->name);

Or these to pr_debug/pr_dbg (for use with dynamic_debug).

I don't think it gives an advantage to emit debug messages which were designed
solely for debugging purposes before.

I would actually favour the dynamic_debug method.

Greetings,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html