lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <520BD2E3.9080606@cogentembedded.com>
Date:	Wed, 14 Aug 2013 22:56:35 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Libo Chen <clbchenlibo.chen@...wei.com>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Li Zefan <lizefan@...wei.com>, leoli@...escale.com,
	linuxppc-dev@...ts.ozlabs.org, pantelis.antoniou@...il.com,
	vbordug@...mvista.com, Greg KH <gregkh@...uxfoundation.org>,
	jg1.han@...sung.com
Subject: Re: [PATCH RESEND 0/8] use platform_{get,set}_drvdata()

On 08/14/2013 07:36 AM, Libo Chen wrote:

> We can use the wrapper functions platform_{get,set}_drvdata() instead of
> dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user.
>
> Also, unnecessary dev_set_drvdata() is removed, because the driver core
> clears the driver data to NULL after device_release or on probe failure.

    Saying "also" in the changelog is usually a good sign that the patch 
should be split.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ