netdev - Re: [PATCHv2 net-next] 6lowpan: handle only real link-local addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130814211658.GA2075@x61s.8.8.8.8>
Date:	Wed, 14 Aug 2013 23:17:01 +0200
From:	Alexander Aring <alex.aring@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com,
	linux-zigbee-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCHv2 net-next] 6lowpan: handle only real link-local addresses

Hi David,

On Wed, Aug 14, 2013 at 12:53:46PM -0700, David Miller wrote:
> From: Alexander Aring <alex.aring@...il.com>
> Date: Wed, 14 Aug 2013 13:01:07 +0200
> 
> > A link-local address isn't fe80::/10 it's fe80::/64
> > see http://tools.ietf.org/html/rfc4291#section-2.5.6
> > for more details.
> > 
> > Also fix a comment issue "local link" -> "link-local"
> > 
> > Signed-off-by: Alexander Aring <alex.aring@...il.com>
> > Reviewed-by: Werner Almesberger <werner@...esberger.net>
> 
> You still haven't addressed my biggest concern.
> 
Sorry, I thought that was the missing "net-next" tag in the subject.

> What order do I apply this patch relative to the other 6?
> 
This patch is a fix for the compression of an address. To make the right
compression on a link-local address.

So this patch has nothing to do for the address uncompression fix
(the patch serie should fix the uncompression of addresses). This is a
bigger patch serie because we make a major rewrite of this function.

The order doesn't matter for this patch. Necessary is that the patch
series will apply in the order 1 to 6. So you can apply this patch
before or afterwards the patch-series.

> Don't make me guess, instead place this patch into the necessary
> place within the series of 6 patches.
> 
I can understand that. This patches only fixes some address behaviour
which is in the current implementation wrong. But there are several
other problems with the current 6LoWPAN implementation.
I don't know which is the right place for these patches, because it is
a big change and the 6LoWPAN implementation is broken anyway.

> I'm not applying any of this until you can submit it properly.
> 
Ok, please let me know what should I do to submit it properly.

Thanks

Regards
Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html