netdev - Re: [PATCH 2/3 v3] ipv6: convert the uses of ADBG and remove the superfluous parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Aug 2013 20:44:07 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ding Tianhong <dingtianhong@...wei.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>,
	Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/3 v3] ipv6: convert the uses of ADBG and remove the
 superfluous parentheses

On Wed, 2013-08-14 at 11:36 +0800, Ding Tianhong wrote:
> Just follow the Joe Perches's opinion, it is a better way to fix the
> style errors.

[]

> Signed-off-by: Joe Perches <joe@...ches.com>

Nope, not signed by me.  I sent you a suggestion.
Please don't add Signed-off-by: signatures for others.
Maybe you might use Suggested-by:

> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>

> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c

> @@ -99,9 +99,9 @@
>  #define ACONF_DEBUG 2
>  
>  #if ACONF_DEBUG >= 3
> -#define ADBG(x) printk x
> +#define ADBG(fmt, ...) printk(fmt, ##__VA_ARGS__)
>  #else
> -#define ADBG(x)
> +#define ADBG(fmt, ...) do {} while (0)

btw:  The macro I suggested will always verify format
and arguments.  This will not.

#define ADBG(fmt, ...) do { if (0) printk(fmt, ##__VA_ARGS__); } while (0)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html