| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1376586173-4242-2-git-send-email-vyasevic@redhat.com> Date: Thu, 15 Aug 2013 13:02:52 -0400 From: Vlad Yasevich <vyasevic@...hat.com> To: netdev@...r.kernel.org Cc: mst@...hat.com, Vlad Yasevich <vyasevic@...hat.com> Subject: [PATCH v3 1/2] macvtap: include all checksum offloads in TUN_OFFLOAD mask The features of the macvlan are based on the features of lower device and thus can have checksum featurs other then IFF_F_HW_CSUM set. However, TUN_OFFLOAD mask only includes IFF_F_HW_CSUM. Thus when performing gso segmentation during macvtap_forward(), it is possbile to end up with skbs that have ip_summed set to CHECKSUM_PARTIAL. This is incorrect when the user turns off checksum offloading. Include all possible checksum offload values so that we'll properly mask them off when performing GSO. Signed-off-by: Vlad Yasevich <vyasevic@...hat.com> --- drivers/net/macvtap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c index b51db2a..8121358 100644 --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -65,7 +65,7 @@ static struct cdev macvtap_cdev; static const struct proto_ops macvtap_socket_ops; -#define TUN_OFFLOADS (NETIF_F_HW_CSUM | NETIF_F_TSO_ECN | NETIF_F_TSO | \ +#define TUN_OFFLOADS (NETIF_F_ALL_CSUM | NETIF_F_TSO_ECN | NETIF_F_TSO | \ NETIF_F_TSO6 | NETIF_F_UFO) #define RX_OFFLOADS (NETIF_F_GRO | NETIF_F_LRO) /* -- 1.8.1.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists