netdev - Re: [PATCH v3 0/7] net: use platform_{get,set}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130815.153903.859166500375208182.davem@davemloft.net>
Date:	Thu, 15 Aug 2013 15:39:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	clbchenlibo.chen@...wei.com
Cc:	netdev@...r.kernel.org, lizefan@...wei.com, leoli@...escale.com,
	linuxppc-dev@...ts.ozlabs.org, pantelis.antoniou@...il.com,
	vbordug@...mvista.com, gregkh@...uxfoundation.org,
	jg1.han@...sung.com, sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH v3 0/7] net: use platform_{get,set}_drvdata()

From: David Miller <davem@...emloft.net>
Date: Thu, 15 Aug 2013 15:23:59 -0700 (PDT)

> From: Libo Chen <clbchenlibo.chen@...wei.com>
> Date: Thu, 15 Aug 2013 21:01:17 +0800
> 
>> Use the wrapper functions for getting and setting the driver data using
>> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
>> so we can directly pass a struct platform_device.
>> 
>> changelog v3:
>> 	remove modify about dev_set_drvdata()
>> changelog v2:
>> 	this version add modify record about dev_set_drvdata().
> 
> Series applied.

Actually, I had to revert, these patches break the build.

drivers/net/ethernet/sun/sunhme.c: In function ‘happy_meal_pci_probe’:
drivers/net/ethernet/sun/sunhme.c:3114:2: error: implicit declaration of function ‘platform_set_drvdata’ [-Werror=implicit-function-declaration]
drivers/net/ethernet/sun/sunhme.c: In function ‘happy_meal_pci_remove’:
drivers/net/ethernet/sun/sunhme.c:3162:9: error: implicit declaration of function ‘platform_get_drvdata’ [-Werror=implicit-function-declaration]
drivers/net/ethernet/sun/sunhme.c:3162:26: warning: initialization makes pointer from integer without a cast [enabled by default]