netdev - Re: [PATCH net] net: tg3: fix NULL pointer dereference in tg3_io_error_detected and tg3_io_slot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130815.010726.719593168454341579.davem@davemloft.net>
Date:	Thu, 15 Aug 2013 01:07:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nsujir@...adcom.com
Cc:	netdev@...r.kernel.org, dborkman@...hat.com,
	shangw@...ux.vnet.ibm.com, mchan@...adcom.com
Subject: Re: [PATCH net] net: tg3: fix NULL pointer dereference in
 tg3_io_error_detected and tg3_io_slot_reset

From: "Nithin Nayak Sujir" <nsujir@...adcom.com>
Date: Tue, 13 Aug 2013 11:45:13 -0700

> From: Daniel Borkmann <dborkman@...hat.com>
> 
> Commit d8af4dfd8 ("net/tg3: Fix kernel crash") introduced a possible
> NULL pointer dereference in tg3 driver when !netdev || !netif_running(netdev)
> condition is met and netdev is NULL. Then, the jump to the 'done' label
> calls dev_close() with a netdevice that is NULL. Therefore, only call
> dev_close() when we have a netdevice, but one that is not running.
> 
> [ Add the same checks in tg3_io_slot_reset() per Gavin Shan - by Nithin
> Nayak Sujir ]
> 
> Reported-by: Dave Jones <davej@...hat.com>
> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>
> Cc: Gavin Shan <shangw@...ux.vnet.ibm.com>
> Cc: Michael Chan <mchan@...adcom.com>
> Signed-off-by: Nithin Nayak Sujir <nsujir@...adcom.com>

Can I get some reviews from the Broadcom folks?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html